Fix mcp loading status #1919
Merged
Fix mcp loading status #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e server in the client list
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1919 +/- ##
=======================================
Coverage 16.75% 16.75%
=======================================
Files 213 213
Lines 20704 20704
Branches 871 871
=======================================
Hits 3468 3468
Misses 17236 17236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
evanliu048
approved these changes
May 20, 2025
brandonskiser
pushed a commit
that referenced
this pull request
May 21, 2025
* precomputes total number of servers in loading prior to spawning display task * changes display task to use async task instead of spawn blocking * waits on notify instead of display task for initial loading * includes time taken in warning and error * adds slash command to show mcp server load messages * includes mcps that fail to start in /mcp * surfaces command error for mcp servers in non-interactive mode * only surfaces timeout warning in non-interactive mode with one or more server in the client list * adds copy change for /mcp * uses a hash set of server names to keep track of the number of initialized servers * only shows mcp non-interactive msg in non-interactive mode
This was referenced May 21, 2025
hayemaxi
pushed a commit
to hayemaxi/amazon-q-developer-cli
that referenced
this pull request
May 22, 2025
* precomputes total number of servers in loading prior to spawning display task * changes display task to use async task instead of spawn blocking * waits on notify instead of display task for initial loading * includes time taken in warning and error * adds slash command to show mcp server load messages * includes mcps that fail to start in /mcp * surfaces command error for mcp servers in non-interactive mode * only surfaces timeout warning in non-interactive mode with one or more server in the client list * adds copy change for /mcp * uses a hash set of server names to keep track of the number of initialized servers * only shows mcp non-interactive msg in non-interactive mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1856
The TLDR is that because tool list calls are now done passively, early errors with mcp server load is terminating the mcp server loading status task prematurely.
Description of changes:
/mcpslash command to show server load records.Testing some workflows:
Added tip:
/mcpwith partial loaded servers:/mcpwith all servers loaded:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.